Skip to content

Conversation

@adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Media queries provides a much more efficient re-rendering, in that it only re-renders the page when the breakpoints are hit and not when the screen is resized (when using useWindowSize)

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 2, 2024 3:04am

<BreakpointProvider>
<Router />
<AppContent />
</BreakpointProvider>
Copy link
Contributor Author

@adrienne-deriv adrienne-deriv Feb 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faster re-rendering:

Screen.Recording.2024-02-02.at.10.42.28.AM.mov

@adrienne-deriv adrienne-deriv marked this pull request as ready for review February 2, 2024 02:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
3.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13299](https://github.com/binary-com/deriv-app/pull/13299)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-use-media-query.binary.sx?qa_server=red.derivws.com&app_id=23820
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-p2p-v2-use-media-query.binary.sx
- **App ID**: `23820`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-p2p-v2-use-media-query.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 34.783% (-0.01%) from 34.793%
when pulling 50c2ded on adrienne-deriv:p2p-v2-use-media-query
into 789d7c8 on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants