-
Notifications
You must be signed in to change notification settings - Fork 394
[TRAH] shahzaib / move real signup wizard trigger to ui provider #13302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TRAH] shahzaib / move real signup wizard trigger to ui provider #13302
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-move-signup-trigger-to-961238.binary.sx/ |
| // Add other UI states here | ||
| accountType?: string; | ||
| isSignupWizardOpen?: boolean; | ||
| isSignupWizardOpen: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahzaib-deriv If we end up with reactmodal for all modals, we can keep modalProvider for hiding/showing all the modals. This way we can separate the responsibility of each provider, CFD, UI, Modal
What do you think?
08e631c
|
|
⏳ Generating Lighthouse report... |

Changes:
This PR focuses on moving the signup wizard trigger to UI provider