Skip to content

Conversation

@shahzaib-deriv
Copy link
Contributor

Changes:

This PR focuses on moving the signup wizard trigger to UI provider

@vercel
Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 2, 2024 7:58am

@shahzaib-deriv shahzaib-deriv changed the title [TRAH] moved signup trigger target to ui provider [TRAH] shahzaib / move signup trigger target to ui provider Feb 2, 2024
@shahzaib-deriv shahzaib-deriv changed the title [TRAH] shahzaib / move signup trigger target to ui provider [TRAH] shahzaib / move signup trigger to ui provider Feb 2, 2024
@shahzaib-deriv shahzaib-deriv changed the title [TRAH] shahzaib / move signup trigger to ui provider [TRAH] shahzaib / move real signup wizard trigger to ui provider Feb 2, 2024
hamza-deriv
hamza-deriv previously approved these changes Feb 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13302](https://github.com/binary-com/deriv-app/pull/13302)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-move-signup-trigger-to-961238.binary.sx?qa_server=red.derivws.com&app_id=24097
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-move-signup-trigger-to-961238.binary.sx
- **App ID**: `24097`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-move-signup-trigger-to-961238.binary.sx/

// Add other UI states here
accountType?: string;
isSignupWizardOpen?: boolean;
isSignupWizardOpen: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shahzaib-deriv If we end up with reactmodal for all modals, we can keep modalProvider for hiding/showing all the modals. This way we can separate the responsibility of each provider, CFD, UI, Modal
What do you think?

@coveralls
Copy link

coveralls commented Feb 2, 2024

Coverage Status

coverage: 34.822% (+0.03%) from 34.793%
when pulling 08e631c on shahzaib-deriv:move-signup-trigger-to-UI-provider
into 789d7c8 on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2024

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants