Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Add checkbox to Personal Details and Terms of use page in real account signup

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 8, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Feb 8, 2024
@vercel
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 8, 2024 7:32am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13445](https://github.com/binary-com/deriv-app/pull/13445)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-realaccou-3c2ebc.binary.sx?qa_server=red.derivws.com&app_id=24043
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-realaccou-3c2ebc.binary.sx
- **App ID**: `24043`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-realaccou-3c2ebc.binary.sx/

@coveralls
Copy link

coveralls commented Feb 8, 2024

Coverage Status

coverage: 35.774% (-0.006%) from 35.78%
when pulling 9faa639 on thisyahlen-deriv:thisyahlen/real_account_signup_checkboxs
into 13d0f58 on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hirad-deriv hirad-deriv merged commit 1157243 into deriv-com:master Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants