Skip to content

yashim/feat: add cutoff mechanism #13462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 14, 2024
Merged

yashim/feat: add cutoff mechanism #13462

merged 17 commits into from
Feb 14, 2024

Conversation

@yashim-deriv
Copy link
Contributor

@yashim-deriv yashim-deriv commented Feb 8, 2024

Changes:

  • Added cutoff mechanism when website is down
  • Update to use DerivAPI blockRequest() method to stop all subsequent requests and subscribe

Screenshots:

@boring-cyborg boring-cyborg bot added the Core label Feb 8, 2024
@vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 14, 2024 3:16am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/13462](https://github.com/binary-com/deriv-app/pull/13462)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yashim-deriv-cutoffmechanismserverstatus.binary.sx?qa_server=red.derivws.com&app_id=24226
    - **Original**: https://deriv-app-git-fork-yashim-deriv-cutoffmechanismserverstatus.binary.sx
- **App ID**: `24226`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yashim-deriv-cutoffmechanismserverstatus.binary.sx/

@coveralls
Copy link

coveralls commented Feb 8, 2024 •
edited
Loading

Coverage Status

coverage: 36.113% (-0.004%) from 36.117%
when pulling 3b681ce on yashim-deriv:cutoff_mechanism_server_status
into 472c26d on binary-com:master.

ghost
ghost previously approved these changes Feb 8, 2024
View reviewed changes
ghost
ghost reviewed Feb 8, 2024
View reviewed changes
ghost
ghost reviewed Feb 8, 2024
View reviewed changes
hamza-deriv
hamza-deriv reviewed Feb 9, 2024
View reviewed changes
@yashim-deriv yashim-deriv dismissed stale reviews from balakrishna-deriv and ghost via f89887c February 12, 2024 05:08
matin-deriv
matin-deriv previously approved these changes Feb 12, 2024
View reviewed changes
tristam-deriv
tristam-deriv reviewed Feb 13, 2024
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yashim-deriv yashim-deriv merged commit bf855e0 into deriv-com:master Feb 14, 2024
akmal-deriv pushed a commit that referenced this pull request Feb 14, 2024
@yashim-deriv @akmal-deriv
yashim/feat: add cutoff mechanism (#13462)
2e63488 
* feat: add cutoff mechanism

* fix: comment

* fix: maintenance notice

* fix: comment

* chore: update to @deriv/deriv-api v1.0.14

* fix: avoid persisting error state via localStorage

* refactor: move status check to utils

* chore: rename variables

* fix: notification filtering & wrong object name

* fix: pending state

* fix: notifcations not showing

* feat: add randomizer to delay

* fix: timeout delay

* fix: reverted timeout change
akmal-deriv pushed a commit that referenced this pull request Feb 15, 2024
@yashim-deriv @akmal-deriv
yashim/feat: add cutoff mechanism (#13462)
b98e784 
* feat: add cutoff mechanism

* fix: comment

* fix: maintenance notice

* fix: comment

* chore: update to @deriv/deriv-api v1.0.14

* fix: avoid persisting error state via localStorage

* refactor: move status check to utils

* chore: rename variables

* fix: notification filtering & wrong object name

* fix: pending state

* fix: notifcations not showing

* feat: add randomizer to delay

* fix: timeout delay

* fix: reverted timeout change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@balakrishna-deriv balakrishna-deriv balakrishna-deriv approved these changes

@matin-deriv matin-deriv matin-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farhan-nurzi-deriv farhan-nurzi-deriv Awaiting requested review from farhan-nurzi-deriv

@mahdiyeh-deriv mahdiyeh-deriv Awaiting requested review from mahdiyeh-deriv

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv vinu-deriv is a code owner

+3 more reviewers

@hamza-deriv hamza-deriv hamza-deriv left review comments

@tristam-deriv tristam-deriv tristam-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AppStore Bot Core Shared Trader

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yashim-deriv @coveralls @balakrishna-deriv @matin-deriv @hamza-deriv @tristam-deriv