Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Fix demo ctrader and dxtrade accounts showing in real if no real account

Screenshots:

Before

Screen.Recording.2024-02-09.at.9.18.40.AM.mov

After

Screen.Recording.2024-02-09.at.9.20.17.AM.mov

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 9, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Feb 9, 2024
@vercel
Copy link

vercel bot commented Feb 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 9, 2024 2:03am

@thisyahlen-deriv thisyahlen-deriv changed the title thisyahlen/fix: demo ctrader and dxtrade accounts showing in real if no real account thisyahlen/TRAH-2828/fix: demo ctrader and dxtrade accounts showing in real if no real account Feb 9, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13471](https://github.com/binary-com/deriv-app/pull/13471)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-fixdemocf-b8eec3.binary.sx?qa_server=red.derivws.com&app_id=31227
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-fixdemocf-b8eec3.binary.sx
- **App ID**: `31227`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-fixdemocf-b8eec3.binary.sx/

@coveralls
Copy link

coveralls commented Feb 9, 2024

Coverage Status

coverage: 35.997% (-0.008%) from 36.005%
when pulling 8df537d on thisyahlen-deriv:thisyahlen/fix_demo_cfd_accounts_showing_in_real
into eb60a44 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Generating Lighthouse report...

@mahdiyeh-deriv mahdiyeh-deriv merged commit 4d45200 into deriv-com:master Feb 9, 2024
vinu-deriv pushed a commit to vinu-deriv/deriv-app that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants