Skip to content

Conversation

@jim-deriv
Copy link
Contributor

Changes:

  • Added test cases for PaymentMethodErrorModal

Screenshots:

coverage

@vercel
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 15, 2024 5:53am

…-1644/payment-method-error-modal-test-casess
@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13574](https://github.com/binary-com/deriv-app/pull/13574)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-feq-1644payment-method-0fd598.binary.sx?qa_server=red.derivws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-feq-1644payment-method-0fd598.binary.sx
- **App ID**: `32820`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 15, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-feq-1644payment-method-0fd598.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Feb 15, 2024

Coverage Status

coverage: 36.423% (+0.003%) from 36.42%
when pulling e106722 on jim-deriv:jim/feq-1644/payment-method-error-modal-test-cases
into bee40e8 on binary-com:master.

@github-actions
Copy link
Contributor

Generating Lighthouse report...

Copy link
Contributor

@ameerul-deriv ameerul-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@farrah-deriv farrah-deriv merged commit d9c38cd into deriv-com:master Feb 19, 2024
@jim-deriv jim-deriv deleted the jim/feq-1644/payment-method-error-modal-test-cases branch September 19, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants