Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

Changes:

  1. Rename PlatformIcons to IconComponent
  2. Add currencies to IconComponent
  3. Remove todo and use IconComponent in Real Account Creation Success Modal

Screenshots:

Screenshot 2024-02-22 at 9 45 50 AM
Screenshot 2024-02-22 at 9 46 18 AM
Screenshot 2024-02-22 at 9 46 32 AM

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Feb 22, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Feb 22, 2024
@vercel
Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Feb 22, 2024 3:37am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13742](https://github.com/binary-com/deriv-app/pull/13742)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-add-curre-b542cc.binary.sx?qa_server=red.derivws.com&app_id=23838
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-add-curre-b542cc.binary.sx
- **App ID**: `23838`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 22, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-add-curre-b542cc.binary.sx/

@coveralls
Copy link

coveralls commented Feb 22, 2024

Coverage Status

coverage: 37.05% (-0.002%) from 37.052%
when pulling c897390 on thisyahlen-deriv:thisyahlen/add-currency-to-IconComponent
into 3e132ef on binary-com:master.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit 55d5ee7 into deriv-com:master Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants