Skip to content

Conversation

@kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Feb 28, 2024

Changes:

  • Method .play() returns a Promise, so .catch() was added. We can't proceed error, because it is equal to undefined (some internal library error), but can handle it by adding an empty callback.
  • Improved performance

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 1, 2024 9:03am

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13860](https://github.com/binary-com/deriv-app/pull/13860)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-907addcatch.binary.sx?qa_server=red.derivws.com&app_id=32751
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-907addcatch.binary.sx
- **App ID**: `32751`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-907addcatch.binary.sx/

@coveralls
Copy link

coveralls commented Feb 28, 2024

Coverage Status

coverage: 37.343% (-11.3%) from 48.63%
when pulling 69f22bc on kate-deriv:kate/DTRA-907/add_catch
into 1186870 on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
4.8% Duplication on New Code

See analysis details on SonarCloud

@maryia-deriv maryia-deriv merged commit cf3da86 into deriv-com:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants