Skip to content

Conversation

@shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Feb 29, 2024

Reading Sources:

this is a spike task to inspect a minor deeplink nuisance raised here

🌏 Today's Discovery: What has changed with iOS 17

Apple iOS 17 deviates from the past User-Agent pattern. From the iOS 17 preview, we can see the “Mac OS X” version is now frozen at 10_15_7.

This part of the User-Agent string can no longer be used to help detect the Apple device if it is in desktop mode. Instead, we must look to the “Version/” information in the string. Let's look at some iPhone User-Agents to visualize this change.

Screenshots:

N/A

@vercel
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 4, 2024 8:56am

@shontzu-deriv shontzu-deriv changed the title refactor: return mt5 deeplink remove installer links redirection shontzu/deep-link-universal-link Feb 29, 2024
@coveralls
Copy link

coveralls commented Feb 29, 2024

Coverage Status

coverage: 37.334%. remained the same
when pulling dbe8918 on shontzu-deriv:deep-link-universal-link
into b72d069 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13902](https://github.com/binary-com/deriv-app/pull/13902)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-deep-link-universal-link.binary.sx?qa_server=red.derivws.com&app_id=23852
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-deep-link-universal-link.binary.sx
- **App ID**: `23852`

@github-actions
Copy link
Contributor

github-actions bot commented Feb 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-deep-link-universal-link.binary.sx/

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@shontzu-deriv shontzu-deriv reopened this Apr 12, 2024
@shontzu-deriv shontzu-deriv marked this pull request as draft April 12, 2024 06:10
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants