Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 1, 2024

Reverted unnecessary skip.

Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel
Copy link

vercel bot commented Mar 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 1, 2024 7:44am

@ghost ghost temporarily deployed to Preview March 1, 2024 07:08 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview March 1, 2024 07:08 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
10.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Mar 1, 2024

Coverage Status

coverage: 37.331% (+0.2%) from 37.177%
when pulling a5a280d on wojciech-deriv:feature/unskip-test
into 20c951c on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/13936](https://github.com/binary-com/deriv-app/pull/13936)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-unskip-test.binary.sx?qa_server=red.derivws.com&app_id=23927
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-unskip-test.binary.sx
- **App ID**: `23927`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 89
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-unskip-test.binary.sx/

@ghost ghost changed the title [WALL] wojtek/feat/unskipped previously skipped test [WALL-3525] wojtek/feat/unskipped previously skipped test Mar 4, 2024
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@heorhi-deriv heorhi-deriv merged commit 6775cc9 into deriv-com:master Mar 4, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants