Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 7, 2024

This PR is to prevent API-v2 from being imported in legacy codebase.
Previously, /api was imported this was and it generated serious hassle (as it was not build for that and was not supposed to be used that way).

Initially I've attempted to use eslint for this, but turned out that eslint use is very inconsistent across packages, while running clean global config was slow, so decided to implement tiny fast script to just check package.json against disallowed imports (so its fast and easy to change if needed). But feel free to update / raise PR with better solution if you have one at hand.

@ghost ghost requested review from balakrishna-deriv and yashim-deriv as code owners March 7, 2024 05:27
@vercel
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 7, 2024 7:43am

@ghost ghost temporarily deployed to Preview March 7, 2024 05:28 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview March 7, 2024 05:28 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14027](https://github.com/binary-com/deriv-app/pull/14027)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-wojciech-deriv-feature-check-imports-v2.binary.sx?qa_server=red.derivws.com&app_id=32795
    - **Original**: https://deriv-app-git-fork-wojciech-deriv-feature-check-imports-v2.binary.sx
- **App ID**: `32795`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-check-imports-v2.binary.sx/

@ghost ghost temporarily deployed to Preview March 7, 2024 06:54 — with GitHub Actions Inactive
@ghost ghost temporarily deployed to Preview March 7, 2024 06:54 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.5% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

coveralls commented Mar 7, 2024

Coverage Status

coverage: 37.439% (-0.02%) from 37.455%
when pulling 212d838 on wojciech-deriv:feature/check-imports-v2
into fb6e872 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024

Generating Lighthouse report...

@heorhi-deriv heorhi-deriv merged commit e8be5aa into deriv-com:master Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants