-
Notifications
You must be signed in to change notification settings - Fork 394
[WALL-3538] wojtek/prevent api-v2 from being imported to legacy code #14027
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-wojciech-deriv-feature-check-imports-v2.binary.sx/ |
|
|
⏳ Generating Lighthouse report... |




This PR is to prevent API-v2 from being imported in legacy codebase.
Previously, /api was imported this was and it generated serious hassle (as it was not build for that and was not supposed to be used that way).
Initially I've attempted to use eslint for this, but turned out that eslint use is very inconsistent across packages, while running clean global config was slow, so decided to implement tiny fast script to just check package.json against disallowed imports (so its fast and easy to change if needed). But feel free to update / raise PR with better solution if you have one at hand.