Skip to content

Conversation

@ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Updated to latest version of deriv-com/ui library which has the fix for textSize prop

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 13, 2024 1:42am

@coveralls
Copy link

coveralls commented Mar 12, 2024

Coverage Status

coverage: 38.067% (-0.009%) from 38.076%
when pulling d8ac6a7 on ameerul-deriv:Ameerul/fix-button-textsize-not-applying
into 3ce5663 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14112](https://github.com/binary-com/deriv-app/pull/14112)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-ameerul-fix-button-text-e1833c.binary.sx?qa_server=red.derivws.com&app_id=23835
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-ameerul-fix-button-text-e1833c.binary.sx
- **App ID**: `23835`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 25
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-ameerul-fix-button-text-e1833c.binary.sx/

farrah-deriv
farrah-deriv previously approved these changes Mar 12, 2024
mahdiyeh-deriv
mahdiyeh-deriv previously approved these changes Mar 12, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.4% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@farrah-deriv farrah-deriv merged commit e8e7c19 into deriv-com:master Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants