Skip to content

Conversation

@mitra-deriv
Copy link
Contributor

@mitra-deriv mitra-deriv commented Mar 13, 2024

Changes:

We are showing a disclaimer in the account info page for EU in tradershub V2 which we shouldn't.

Screenshots:

Before the fix:

image

After the fix:
Screenshot 2024-03-12 at 12 15 16 PM

@vercel
Copy link

vercel bot commented Mar 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 18, 2024 4:16am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14125](https://github.com/binary-com/deriv-app/pull/14125)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mitra-deriv-to-not-show-eu-disclaimer-5a885b.binary.sx?qa_server=red.derivws.com&app_id=23847
    - **Original**: https://deriv-app-git-fork-mitra-deriv-to-not-show-eu-disclaimer-5a885b.binary.sx
- **App ID**: `23847`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mitra-deriv-to-not-show-eu-disclaimer-5a885b.binary.sx/

@coveralls
Copy link

coveralls commented Mar 13, 2024

Coverage Status

coverage: 38.437% (+0.08%) from 38.356%
when pulling 5caa6f6 on mitra-deriv:to-not-show-eu-disclaimer-in-account-info-page
into 5459c3f on binary-com:master.

@mitra-deriv mitra-deriv marked this pull request as ready for review March 13, 2024 03:50
@thisyahlen-deriv thisyahlen-deriv marked this pull request as ready for review March 18, 2024 03:20
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mahdiyeh-deriv mahdiyeh-deriv merged commit c62a43a into deriv-com:master Mar 18, 2024
@mitra-deriv mitra-deriv deleted the to-not-show-eu-disclaimer-in-account-info-page branch June 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants