[DTRA] / Kate / DTRA-934 / Enable forward starting contract from Smartrader #14181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion in recen positions
kate-deriv
requested review from
ali-hosseini-deriv,
mahdiyeh-deriv,
maryia-deriv and
matin-deriv
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-934forwardstarti-07af52.binary.sx/ |
kate-deriv
commented
Mar 14, 2024
packages/components/src/components/positions-drawer-card/positions-drawer-card.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
commented
Mar 14, 2024
packages/components/src/components/positions-drawer-card/positions-drawer-card.tsx
Outdated
Show resolved
Hide resolved
kate-deriv
commented
Mar 14, 2024
kate-deriv
commented
Mar 14, 2024
kate-deriv
commented
Mar 14, 2024
balakrishna-deriv
previously approved these changes
Mar 20, 2024
maryia-deriv
previously approved these changes
Mar 20, 2024
kate-deriv
dismissed stale reviews from maryia-deriv and balakrishna-deriv
via
92cb821
maryia-deriv
previously approved these changes
Mar 20, 2024
maryia-deriv
suggested changes
Mar 21, 2024
| isForwardStartingBuyTransaction( | ||
| row.action_type, | ||
| row.shortcode, | ||
| row.purchase_time || row.transaction_time |
Contributor
There was a problem hiding this comment.
Can we pass a single row param and destructure/use the properties we need inside isForwardStartingBuyTransaction? :)
same in data-table.tsx
Contributor
Author
There was a problem hiding this comment.
But row object has a lot of fields, a we need only 3. What are the benefits of passing all object? Moreover, in that case it won't be obvious which exactly information do we need
| const contract_type = extractInfoFromShortcode(row_obj.shortcode)?.category?.toUpperCase(); | ||
| const unsupportedContractConfig = getUnsupportedContracts()[contract_type as TUnsupportedContractType]; | ||
| const shouldShowForwardStartingNotification = | ||
| isForwardStarting(row_obj.shortcode, row_obj.purchase_time || row_obj.transaction_time) && |
Contributor
There was a problem hiding this comment.
Can we pass a single row_obj param to isForwardStarting and take all necessary properties from it inside isForwardStarting? :)
Contributor
Author
There was a problem hiding this comment.
Please, refer to answer #14181 (comment)
henry-deriv
approved these changes
Mar 22, 2024
|
maryia-deriv
approved these changes
Mar 22, 2024
Contributor
|
⏳ Generating Lighthouse report... |
Dhruv-deriv
pushed a commit
to Dhruv-deriv/deriv-app
that referenced
this pull request
Mar 26, 2024
…trader (deriv-com#14181) * feat: enable forward starting contracts on descktop and modify filtration in recen positions * feat: add filtration for mobiile recent positions and refactor failing tests * refactor: comments * refactor: modify checking function * refactor: rename function * refactor: improve type of function arguments * refactor: add tests and remove codesmells * refactor: add timer for hidding notification * refactor: remove code smells * refactor: remove unused code * refactor: fix failing test * refactor: extract logic into the hook * chore: rename and remove extra spaces * refactor: extract duplictaed filtration logic * fix: allow display of manually sold forward contract before starting * refactor: add tests for new function * refactor: apply suggestions regarding destructurization * refactor: apply suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
CALLSPREAD/Spread UpandPUTSPREAD/Spread Downwhich are not available at all our platforms) and forward starting contracts, which haven't started yet. Forward starting contracts, which already HAVE started, are shown.hasContractStartedis based oncontract_infofields (it's comparingcurrent_spot_timeanddate_start) and used in such places as position-drawer-card, position-drawer, open-positions. Second one,hasForwardContractStartedfunction acceptsshortcode, extractingstart_timefrom shortcode and compare withDate.now(). Is used in statement, because there we have no access tocontract_info.Screenshots: