Skip to content

Conversation

@shahzaib-deriv
Copy link
Contributor

Changes:

  • Triggered real account creation after demo account submission.
  • Added trading & financial assessment screens for real account creation.
  • Implemented form progress steps based on EU and non-EU.
  • Closed account selector after switching.

Fixes:

  • Hid crypto currencies section for EU.
  • Closed real account creation after account creation.
  • Closed manage account modal after adding currency.
Screen.Recording.2024-03-18.at.2.10.11.PM.mov
Screen.Recording.2024-03-18.at.2.00.13.PM.mov

@shahzaib-deriv shahzaib-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Mar 18, 2024
@shahzaib-deriv shahzaib-deriv self-assigned this Mar 18, 2024
@vercel
Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 20, 2024 2:55am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14219](https://github.com/binary-com/deriv-app/pull/14219)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-trah-2867trigger-real-2be47e.binary.sx?qa_server=red.derivws.com&app_id=23824
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-trah-2867trigger-real-2be47e.binary.sx
- **App ID**: `23824`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-trah-2867trigger-real-2be47e.binary.sx/

@coveralls
Copy link

coveralls commented Mar 18, 2024

Coverage Status

coverage: 38.548% (-0.01%) from 38.562%
when pulling 5898bfb on shahzaib-deriv:TRAH-2867_trigger-real-account-creation-after-demo-account
into feb87f8 on binary-com:master.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
3.2% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@yashim-deriv yashim-deriv merged commit 8fd7a96 into deriv-com:master Mar 20, 2024
Dhruv-deriv pushed a commit to Dhruv-deriv/deriv-app that referenced this pull request Mar 20, 2024
…nt (deriv-com#14219)

* chore: close account selector after switching

* chore: form progress steps based on eu and non-eu

* chore: trading & financial assessment screens for real account creation

* fix: close manage account modal after adding currency

* fix: close real account creation after account creation

* fix: hide crypto currencies section for EU

* chore: trigger real account creation after demo account submission

* chore: updated docs and comments

---------

Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants