Skip to content

Conversation

@thisyahlen-deriv
Copy link
Contributor

@thisyahlen-deriv thisyahlen-deriv commented Mar 20, 2024

Changes:

  1. Fix console error in the regulation modal

Screenshots:

Before
Screenshot 2024-03-20 at 11 58 16 AM

After

Screen.Recording.2024-03-20.at.12.04.20.PM.mov

@thisyahlen-deriv thisyahlen-deriv added the Trader's Hub PR's that are created to the new trader's hub package label Mar 20, 2024
@thisyahlen-deriv thisyahlen-deriv self-assigned this Mar 20, 2024
@vercel
Copy link

vercel bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 20, 2024 5:26am

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14257](https://github.com/binary-com/deriv-app/pull/14257)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-3087-308789.binary.sx?qa_server=red.derivws.com&app_id=24068
    - **Original**: https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-3087-308789.binary.sx
- **App ID**: `24068`

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-thisyahlen-deriv-thisyahlen-trah-3087-308789.binary.sx/

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 39.111%. remained the same
when pulling 789cd43 on thisyahlen-deriv:thisyahlen/TRAH-3087/fix-console-error-in-regulation-modal
into 6cc1eb0 on binary-com:master.

@yashim-deriv yashim-deriv merged commit 51f8a2b into deriv-com:master Mar 20, 2024
Dhruv-deriv pushed a commit to Dhruv-deriv/deriv-app that referenced this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Trader's Hub PR's that are created to the new trader's hub package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants