Skip to content

Conversation

@shahzaib-deriv
Copy link
Contributor

Changes:

Fix the type error in router component in RouteLinks

Screenshots:

Screenshot 2024-03-27 at 12 34 46 PM

@vercel
Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Mar 27, 2024 5:08am

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14366](https://github.com/binary-com/deriv-app/pull/14366)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shahzaib-deriv-fix-type-error-router-f40e20.binary.sx?qa_server=red.derivws.com&app_id=23815
    - **Original**: https://deriv-app-git-fork-shahzaib-deriv-fix-type-error-router-f40e20.binary.sx
- **App ID**: `23815`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shahzaib-deriv-fix-type-error-router-f40e20.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 39.585% (+0.004%) from 39.581%
when pulling dd92cf0 on shahzaib-deriv:fix/type-error-router-component
into a57f4ee on binary-com:master.

@amina-deriv amina-deriv merged commit a3cccbd into deriv-com:master Mar 27, 2024
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants