Skip to content

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Apr 3, 2024

Changes:

  • Update missing MT5 password validation: Password should have lower and uppercase English letters with numbers.

Screenshots:

image

@vercel
Copy link

vercel bot commented Apr 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 3, 2024 6:54am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14458](https://github.com/binary-com/deriv-app/pull/14458)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-3701update-pas-6858bc.binary.sx?qa_server=red.derivws.com&app_id=23938
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-wall-3701update-pas-6858bc.binary.sx
- **App ID**: `23938`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-wall-3701update-pas-6858bc.binary.sx/

@nijil-deriv nijil-deriv merged commit b4015de into deriv-com:master Apr 3, 2024
@coveralls
Copy link

Coverage Status

coverage: 39.835% (-0.006%) from 39.841%
when pulling 440063c on aizad-deriv:aizad/WALL-3701/update-password-validation
into b9dfdd3 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 39.835% (-0.006%) from 39.841%
when pulling 440063c on aizad-deriv:aizad/WALL-3701/update-password-validation
into b9dfdd3 on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants