Skip to content

Conversation

@adrienne-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Previously eUSDT and tUSDT wallet icons are not showing up due to key mismatch in SVG constants
    After
Screenshot 2024-04-17 at 2 56 50 PM

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 22, 2024 5:19am

@adrienne-deriv adrienne-deriv marked this pull request as ready for review April 17, 2024 06:59
@adrienne-deriv adrienne-deriv requested a review from a user April 17, 2024 06:59
heorhi-deriv
heorhi-deriv previously approved these changes Apr 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14660](https://github.com/binary-com/deriv-app/pull/14660)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-fix-logo-missing-crypt-abca47.binary.sx?qa_server=red.derivws.com&app_id=32806
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-fix-logo-missing-crypt-abca47.binary.sx
- **App ID**: `32806`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-fix-logo-missing-crypt-abca47.binary.sx/

@coveralls
Copy link

coveralls commented Apr 17, 2024

Coverage Status

coverage: 40.167% (+0.06%) from 40.111%
when pulling 4f09b39 on adrienne-deriv:fix-logo-missing-crypto-wallet
into 22b0bcb on binary-com:master.

nijil-deriv
nijil-deriv previously approved these changes Apr 17, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 5b9343b into deriv-com:master Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants