Skip to content

Conversation

@shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Apr 30, 2024

Changes:

  • Added Forgot password functionality on password modal
  • Refactored duplicate send email code

Screenshots:

Screen.Recording.2024-04-30.at.1.32.36.PM.mov

@vercel
Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Apr 30, 2024 6:39am

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/14891](https://github.com/binary-com/deriv-app/pull/14891)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-3883add-th-971db6.binary.sx?qa_server=red.derivws.com&app_id=31586
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-3883add-th-971db6.binary.sx
- **App ID**: `31586`

@github-actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟢 Accessibility 90
🟢 Best practices 92
🟧 SEO 81
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-3883add-th-971db6.binary.sx/

…ionality-of-Forgot-password-button-on-passwordmodal
amina-deriv
amina-deriv previously approved these changes Apr 30, 2024
…countButtonsGroup.tsx

Co-authored-by: Hasan Mobarak <126637868+hasan-deriv@users.noreply.github.com>
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hirad-deriv hirad-deriv merged commit 34ec71e into deriv-com:master Apr 30, 2024
vinu-deriv pushed a commit to vinu-deriv/deriv-app that referenced this pull request May 28, 2024
…ord-button-on-passwordmodal (deriv-com#14891)

* chore: open sentEmailContent modal

* chore: sendEmail handler

* refactor: move duplicate code into hook

* chore: CFDPlatforms consistency

* Update packages/tradershub/src/features/cfd/modals/ButtonGroups/AddAccountButtonsGroup.tsx

Co-authored-by: Hasan Mobarak <126637868+hasan-deriv@users.noreply.github.com>

---------

Co-authored-by: Hasan Mobarak <126637868+hasan-deriv@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants