Skip to content

Conversation

@mitra-deriv
Copy link
Contributor

Changes:

To show the tutorial icon for wallet header on responsice

Screenshots:

Screenshot 2024-05-27 at 3 12 18 PM

@boring-cyborg boring-cyborg bot added the Core label May 27, 2024
@vercel
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 27, 2024 7:35am

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15357](https://github.com/binary-com/deriv-app/pull/15357)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-mitra-deriv-fix-missing-onboarding-icon.binary.sx?qa_server=red.derivws.com&app_id=24190
    - **Original**: https://deriv-app-git-fork-mitra-deriv-fix-missing-onboarding-icon.binary.sx
- **App ID**: `24190`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-mitra-deriv-fix-missing-onboarding-icon.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 42.017% (+0.001%) from 42.016%
when pulling fb196bd on mitra-deriv:fix-missing-onboarding-icon
into f505fd1 on binary-com:master.

@rostislav-deriv
Copy link
Contributor

Hey @mitra-deriv, i've moved this PR commits into #15231 for combined testing of both cards in one testlink since these cards are both related to onboarding 🙇🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants