Skip to content

Conversation

@rostislav-deriv
Copy link
Contributor

@rostislav-deriv rostislav-deriv commented May 28, 2024

Changes:

  • expand the trade modal logic to include cTrader
  • update cTrader-related hooks to override API display_balance

Screenshots:

Screenshot 2024-05-29 at 16 29 03

@vercel
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview May 31, 2024 8:35am

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15399](https://github.com/binary-com/deriv-app/pull/15399)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-4233ct-1edfee.binary.sx?qa_server=red.derivws.com&app_id=24089
    - **Original**: https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-4233ct-1edfee.binary.sx
- **App ID**: `24089`

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rostislav-deriv-rostislav-wall-4233ct-1edfee.binary.sx/

@coveralls
Copy link

coveralls commented May 28, 2024

Coverage Status

coverage: 41.697% (-1.4%) from 43.068%
when pulling b74d8b0 on rostislav-deriv:rostislav/wall-4233/ctrader-balance-missing-in-trade-modal
into 4a6933c on binary-com:master.

ghost
ghost previously approved these changes May 29, 2024
nijil-deriv
nijil-deriv previously approved these changes May 29, 2024
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit f93a88d into deriv-com:master May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants