Skip to content

[UPM-414]/evgeniy/remove passkey flow #15433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yauheni-deriv wants to merge 89 commits into from
Closed

[UPM-414]/evgeniy/remove passkey flow #15433

yauheni-deriv wants to merge 89 commits into from

Conversation

@yauheni-deriv
Copy link
Contributor

@yauheni-deriv yauheni-deriv commented May 30, 2024 •
edited
Loading

Changes:

  1. Implemented the flow for removing passkey: components and API hook.
  2. Refactored register and rename hooks to accept onSuccess function. It allowed to refactor passkeys.tsx and remove unnecessary useEffects.
  3. removed import React from 'react'
  4. tracking error moved outside of API hooks
  5. added tracking events
  6. added lazyl oading for passkeys menu to reduce the initial loaded account package size
after_lazy_load before_lazy_load

yauheni-deriv and others added 24 commits May 18, 2024 18:25
@yauheni-deriv
refactor: [UPM-1080]/evgeniy/refactor passkeys code
60c5d24
@yauheni-deriv
refactor: tests and code completion
9c25d46
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
b8478ab
@yauheni-deriv
refactor: do not fetch passkeys list, when no need to open the modal
816a47f
@yauheni-deriv
refactor: tests fix, remove btn loader status, icons change
829737a
@yauheni-deriv
refactor: do not call for passkeys if local storage value is false
2e6a61d
@yauheni-deriv
chore: added todo for tracking events
f7000ce
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
ed514ef
@yauheni-deriv
refactor: client store remove unnecessary checks, tests, icons
a96370d
@yauheni-deriv
chore: skip changing the state for created status
b6a607d
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
8b22e80
@yauheni-deriv
refactor: removed unnecessary li tag in modal
707af7c
@yauheni-deriv
chore: rename passkey (#44)
49667db 
* chore: rename passkey

* chore: test fix

* fix: styles for rtl

* refactor: call success event only after success renaming

* chore: hide disabled dropdown item
@yauheni-deriv
Merge branch 'binary-com:master' into evgeniy_upm-1080_refactor-passk…
1810d77 
…eys-code
@yauheni-deriv
chore: review comments
9a9850a
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
9e26fe5
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
9dcf369
@yauheni-deriv
fix: resolve conflicts
40c1688
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
20ddbf2
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
88296fb
@yauheni-deriv
fix: accidentally removed clsx import
dbc273b
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-1080_refactor-passkeys-code
6ecb556
@yauheni-deriv
Merge branch 'master' into evgeniy_upm-414_remove-passkey-flow
fbde111
@yauheni-deriv
chore: [UPM-414]/evgeniy/remove passkey flow
5843101
review-deriv
review-deriv reviewed May 30, 2024
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 30, 2024 11:03am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 30, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fasihali-deriv fasihali-deriv fasihali-deriv approved these changes

@amina-deriv amina-deriv amina-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@adrienne-deriv adrienne-deriv Awaiting requested review from adrienne-deriv

@thisyahlen-deriv thisyahlen-deriv Awaiting requested review from thisyahlen-deriv

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv

@aizad-deriv aizad-deriv Awaiting requested review from aizad-deriv

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv

+3 more reviewers

@review-deriv review-deriv review-deriv left review comments

@utkarsha-deriv utkarsha-deriv utkarsha-deriv approved these changes

@likhith-deriv likhith-deriv likhith-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Account

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yauheni-deriv @coveralls @amina-deriv @likhith-deriv @fasihali-deriv @utkarsha-deriv @review-deriv