Skip to content

Conversation

@farabi-deriv
Copy link
Contributor

Changes:

  • Fixed rudderstack issue with subpage name for quick strategy open and close event
  • Unified tutorial tab events to a single rudderstack component

@vercel
Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 7, 2024 7:47am

@coveralls
Copy link

Coverage Status

coverage: 43.285% (+0.001%) from 43.284%
when pulling fe9831c on farabi-deriv:farabi/bot-1871/update-rudderstack-events-for-qs-and-tutorial
into f762463 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15532](https://github.com/binary-com/deriv-app/pull/15532)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1871update-ru-c86e85.binary.sx?qa_server=red.derivws.com&app_id=32820
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-1871update-ru-c86e85.binary.sx
- **App ID**: `32820`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 34
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-1871update-ru-c86e85.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 43.285% (+0.001%) from 43.284%
when pulling 633be22 on farabi-deriv:farabi/bot-1871/update-rudderstack-events-for-qs-and-tutorial
into f762463 on binary-com:master.

sandeep-deriv
sandeep-deriv previously approved these changes Jun 7, 2024
…pdate-rudderstack-events-for-qs-and-tutorial
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
6.6% Duplication on New Code

See analysis details on SonarCloud

@coveralls
Copy link

Coverage Status

coverage: 43.326% (-0.002%) from 43.328%
when pulling eeb4436 on farabi-deriv:farabi/bot-1871/update-rudderstack-events-for-qs-and-tutorial
into 70564b0 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 43.329% (+0.001%) from 43.328%
when pulling eeb4436 on farabi-deriv:farabi/bot-1871/update-rudderstack-events-for-qs-and-tutorial
into 70564b0 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 43.326% (-0.002%) from 43.328%
when pulling eeb4436 on farabi-deriv:farabi/bot-1871/update-rudderstack-events-for-qs-and-tutorial
into 70564b0 on binary-com:master.

@farabi-deriv farabi-deriv merged commit 35daa5d into deriv-com:master Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants