Skip to content

Conversation

@aizad-deriv
Copy link
Contributor

@aizad-deriv aizad-deriv commented Jun 19, 2024

Changes:

  • Refactor OptionsAndMultipliersListing component
  • Use WalletMarketIcon component
  • Remove imports from constant files and instead import required icons inside of WalletMarketIcon
  • Separate LinkTItle as its own child component
  • Remove unused icons

Link to CU: https://app.clickup.com/t/20696747/WALL-4436

Screenshots:

Screenshot 2024-06-19 at 1 44 35 PM

@aizad-deriv aizad-deriv self-assigned this Jun 19, 2024
@aizad-deriv aizad-deriv requested a review from a user June 19, 2024 05:47
@vercel
Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 19, 2024 6:49am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15695](https://github.com/binary-com/deriv-app/pull/15695)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aizad-deriv-aizad-refactor-options-mu-6f1159.binary.sx?qa_server=red.derivws.com&app_id=31584
    - **Original**: https://deriv-app-git-fork-aizad-deriv-aizad-refactor-options-mu-6f1159.binary.sx
- **App ID**: `31584`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aizad-deriv-aizad-refactor-options-mu-6f1159.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 44.914%. remained the same
when pulling c2f2164 on aizad-deriv:aizad/refactor-options-multiplier-listing
into 381f10e on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.91% (-0.004%) from 44.914%
when pulling 1eab2f4 on aizad-deriv:aizad/refactor-options-multiplier-listing
into 381f10e on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.909% (-0.005%) from 44.914%
when pulling 1eab2f4 on aizad-deriv:aizad/refactor-options-multiplier-listing
into 381f10e on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 44.97% (+0.06%) from 44.914%
when pulling 1eab2f4 on aizad-deriv:aizad/refactor-options-multiplier-listing
into 381f10e on binary-com:master.

@aizad-deriv aizad-deriv changed the title [WALL] Aizad/Refactor Options Multiplier Listings [WALL] Aizad/WALL-4436/Refactor Options Multiplier Listings Jun 20, 2024
@coveralls
Copy link

Coverage Status

coverage: 45.227% (+0.3%) from 44.914%
when pulling 1eab2f4 on aizad-deriv:aizad/refactor-options-multiplier-listing
into 381f10e on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.226% (+0.3%) from 44.914%
when pulling 1eab2f4 on aizad-deriv:aizad/refactor-options-multiplier-listing
into 381f10e on binary-com:master.

@nijil-deriv nijil-deriv merged commit 949aeda into deriv-com:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants