Skip to content

Conversation

@shontzu-deriv
Copy link
Contributor

Changes:

  • The root cause of this issue is that in the swap-free jurisdiction model, we are only filtering for market_type = "all"
  • it is not unique to swap-free / zero-spread
  • use product to uniquely identify swap-free

Screenshots:

image image

@vercel
Copy link

vercel bot commented Jun 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 21, 2024 10:55am

@shontzu-deriv shontzu-deriv changed the title Shontzu/cfds 4248/sf zs patch [CFDS] shontzu/CFDS-4248/Add-product-filtering-for-swap-free-jurisdiction-modal Jun 21, 2024
@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15735](https://github.com/binary-com/deriv-app/pull/15735)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4248sf-zs-patch.binary.sx?qa_server=red.derivws.com&app_id=31580
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4248sf-zs-patch.binary.sx
- **App ID**: `31580`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 41
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-cfds-4248sf-zs-patch.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 45.362% (-0.003%) from 45.365%
when pulling 7e0d71c on shontzu-deriv:shontzu/CFDS-4248/sf-zs-patch
into 21d99be on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.365%. remained the same
when pulling 7e0d71c on shontzu-deriv:shontzu/CFDS-4248/sf-zs-patch
into 21d99be on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants