Skip to content

Conversation

@kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Jun 25, 2024

Changes:

  • Added CALLE/PUTE to config in order to send it together with CALL/PUT in the array of contract_type to profit_table request, when user applies 'Rise/Fall' filter.
  • Refactor existing tests

Screenshots:

Screenshot 2024-06-25 at 11 23 37 AM

@boring-cyborg boring-cyborg bot added the Trader label Jun 25, 2024
@vercel
Copy link

vercel bot commented Jun 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jun 25, 2024 8:57am

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15768](https://github.com/binary-com/deriv-app/pull/15768)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1368calleputefiltration.binary.sx?qa_server=red.derivws.com&app_id=23819
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1368calleputefiltration.binary.sx
- **App ID**: `23819`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 35
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-1368calleputefiltration.binary.sx/

maryia-deriv
maryia-deriv previously approved these changes Jun 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 45.552% (+0.004%) from 45.548%
when pulling d7acc19 on kate-deriv:kate/DTRA-1368/calle_pute_filtration
into 93e7fd1 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.553% (+0.005%) from 45.548%
when pulling d7acc19 on kate-deriv:kate/DTRA-1368/calle_pute_filtration
into 93e7fd1 on binary-com:master.

@kate-deriv kate-deriv changed the title DTRA-1368 / Kate / Position and Contract Details Page refactor: add CALLE/PUTE filtration [WIP] DTRA-1368 / Kate / Position and Contract Details Page refactor: add CALLE/PUTE filtration Jun 25, 2024
@coveralls
Copy link

Coverage Status

coverage: 45.555% (+0.007%) from 45.548%
when pulling 37a44ba on kate-deriv:kate/DTRA-1368/calle_pute_filtration
into 93e7fd1 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.552% (+0.004%) from 45.548%
when pulling 37a44ba on kate-deriv:kate/DTRA-1368/calle_pute_filtration
into 93e7fd1 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.554% (+0.006%) from 45.548%
when pulling 37a44ba on kate-deriv:kate/DTRA-1368/calle_pute_filtration
into 93e7fd1 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.556% (+0.008%) from 45.548%
when pulling 37a44ba on kate-deriv:kate/DTRA-1368/calle_pute_filtration
into 93e7fd1 on binary-com:master.

@balakrishna-deriv balakrishna-deriv merged commit babb605 into deriv-com:master Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants