Skip to content

Conversation

@fasihali-deriv
Copy link
Contributor

Changes:

Added lazy loading for some section like ApiToken, TwoFactorAuthentication and SelfExclusion

@vercel
Copy link

vercel bot commented Jun 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 4, 2024 8:23am

@coveralls
Copy link

Coverage Status

coverage: 45.527%. remained the same
when pulling 4e32040 on fasihali-deriv:implement-lazy-load-on-sections
into 1a8c4fa on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15839](https://github.com/binary-com/deriv-app/pull/15839)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-fasihali-deriv-implement-lazy-load-on-03344a.binary.sx?qa_server=red.derivws.com&app_id=23883
    - **Original**: https://deriv-app-git-fork-fasihali-deriv-implement-lazy-load-on-03344a.binary.sx
- **App ID**: `23883`

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-fasihali-deriv-implement-lazy-load-on-03344a.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 45.302% (-0.008%) from 45.31%
when pulling c7e42ff on fasihali-deriv:implement-lazy-load-on-sections
into 6966640 on binary-com:master.

@coveralls
Copy link

Coverage Status

coverage: 45.302% (-0.008%) from 45.31%
when pulling 98b3ff3 on fasihali-deriv:implement-lazy-load-on-sections
into 6966640 on binary-com:master.

Copy link
Contributor

@amina-deriv amina-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 45.303% (-0.007%) from 45.31%
when pulling c2dde5e on fasihali-deriv:implement-lazy-load-on-sections
into 6966640 on binary-com:master.

@amina-deriv amina-deriv merged commit 0b66e02 into deriv-com:master Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants