Skip to content

Conversation

@niloofar-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 2, 2024 7:16am

@gitguardian
Copy link

gitguardian bot commented Jul 2, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 009a0c3 packages/appstore/src/helpers/trustpilot-helper.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/15910](https://github.com/binary-com/deriv-app/pull/15910)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloofar-deriv-niloofar-trustpilot.binary.sx?qa_server=red.derivws.com&app_id=24048
    - **Original**: https://deriv-app-git-fork-niloofar-deriv-niloofar-trustpilot.binary.sx
- **App ID**: `24048`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-niloofar-deriv-niloofar-trustpilot.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 44.931% (-0.003%) from 44.934%
when pulling 009a0c3 on niloofar-deriv:niloofar/trustpilot
into a8c2dde on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants