Skip to content

Conversation

@niloofar-deriv
Copy link
Contributor

@niloofar-deriv niloofar-deriv commented Jul 24, 2024

Changes:

Since @sergei-deriv is on leave I created this PR for addressing the issues we faced on his PR.
#15892

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Jul 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 26, 2024 9:30am

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16172](https://github.com/binary-com/deriv-app/pull/16172)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-niloofar-deriv-bug-fix.binary.sx?qa_server=red.derivws.com&app_id=32085
    - **Original**: https://deriv-app-git-fork-niloofar-deriv-bug-fix.binary.sx
- **App ID**: `32085`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 31
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-niloofar-deriv-bug-fix.binary.sx/

@niloofar-deriv niloofar-deriv changed the title Bug fix [TRAH] Sergei / TRAH - 3546 / Take user to deposit screen after real account creation for ROW Jul 24, 2024
@niloofar-deriv niloofar-deriv changed the title [TRAH] Sergei / TRAH - 3546 / Take user to deposit screen after real account creation for ROW [TRAH] Sergei / Niloofar / TRAH - 3546 / Take user to deposit screen after real account creation for ROW Jul 24, 2024
@coveralls
Copy link

coveralls commented Jul 24, 2024

Coverage Status

coverage: 46.261% (+0.03%) from 46.236%
when pulling 409811b on niloofar-deriv:bug-fix
into a10f85c on binary-com:master.

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@habib-deriv habib-deriv merged commit 9e86851 into deriv-com:master Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants