Skip to content

Conversation

@rupato-deriv
Copy link
Contributor

Fixing the getBlocksInStatement Error

The getBlocksInStatement error occurred because, in the Binary Bot system, we used to load the workspace when we uploaded an XML file. This approach allowed the system to handle blocks that were not present by ensuring they were properly loaded into the workspace. However, in the Deriv Bot system, we now directly load the XML file without initializing the workspace first. As a result, blocks that are referenced in the XML but are not present can lead to errors.

To fix this issue, you need to ensure that the system correctly handles blocks that are missing or not yet loaded when processing the XML. This might involve initializing the workspace or implementing logic to handle missing blocks gracefully.

@vercel
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Jul 29, 2024 10:18am

@rupato-deriv rupato-deriv changed the title fix: backward compatibility Rpuato/fix: getBlocksInStatement trackjs error Jul 29, 2024
@sonarqubecloud
Copy link

@rupato-deriv rupato-deriv changed the title Rpuato/fix: getBlocksInStatement trackjs error Rupato/fix: getBlocksInStatement trackjs error Jul 29, 2024
@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16244](https://github.com/binary-com/deriv-app/pull/16244)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-trackjs-getblocks-cf83de.binary.sx?qa_server=red.derivws.com&app_id=24202
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-trackjs-getblocks-cf83de.binary.sx
- **App ID**: `24202`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-trackjs-getblocks-cf83de.binary.sx/

@coveralls
Copy link

coveralls commented Jul 29, 2024

Coverage Status

coverage: 46.26% (+0.001%) from 46.259%
when pulling 3b31420 on rupato-deriv:Rupato/TrackJS--getBlocksInStatement-undefined-fix
into 0290b58 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2024

Generating Lighthouse report...

@sandeep-deriv sandeep-deriv merged commit 335f744 into deriv-com:master Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants