Skip to content

Conversation

@rupato-deriv
Copy link
Contributor

@rupato-deriv rupato-deriv commented Aug 1, 2024

Update

Blockly V10
Post release of Blockly Update, Fixing the + method for if, else block
updated the blockly mutator method

review-deriv

This comment was marked as outdated.

@vercel
Copy link

vercel bot commented Aug 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 2, 2024 4:40am

@rupato-deriv rupato-deriv changed the title fix: controls if statement Rupato/fix: controls if statement Aug 1, 2024
review-deriv

This comment was marked as outdated.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16332](https://github.com/binary-com/deriv-app/pull/16332)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-for-control-ifs.binary.sx?qa_server=red.derivws.com&app_id=23938
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-fix-for-control-ifs.binary.sx
- **App ID**: `23938`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 39
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-fix-for-control-ifs.binary.sx/

@coveralls
Copy link

coveralls commented Aug 1, 2024

Coverage Status

coverage: 46.537% (-0.006%) from 46.543%
when pulling 68d9139 on rupato-deriv:Rupato/fix-for-control-ifs
into 1094e9e on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 2, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2024

Generating Lighthouse report...

@sandeep-deriv sandeep-deriv merged commit a8091c3 into deriv-com:master Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants