Skip to content

Conversation

@lubega-deriv
Copy link
Contributor

Changes:

  • Added underline to Trader's Hub Learn more link

Before:

Screenshot 2024-08-16 at 11 14 17 AM Screenshot 2024-08-16 at 11 14 30 AM

After:

Screenshot 2024-08-16 at 11 33 20 AM Screenshot 2024-08-16 at 11 33 01 AM

@vercel
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 16, 2024 3:56am

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16517](https://github.com/binary-com/deriv-app/pull/16517)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-trah-3965-traders-hub-op-5c2534.binary.sx?qa_server=red.derivws.com&app_id=31581
    - **Original**: https://deriv-app-git-fork-lubega-deriv-trah-3965-traders-hub-op-5c2534.binary.sx
- **App ID**: `31581`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 29
🟧 Accessibility 70
🟧 Best practices 83
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-trah-3965-traders-hub-op-5c2534.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 46.008% (-0.001%) from 46.009%
when pulling 8265841 on lubega-deriv:TRAH-3965/traders-hub-options-link-underline
into b850216 on binary-com:master.

@jim-deriv jim-deriv merged commit 7356879 into deriv-com:master Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants