Skip to content

Conversation

@jim-deriv
Copy link
Contributor

Changes:

  • Added unit tests for:
    MT5ChangeInvestorPasswordInputsScreen
    MT5ChangeInvestorPasswordSavedScreen
    MT5ChangeInvestorPasswordScreens
    ChangePassword
    MT5ChangePasswordScreens
    TradingPlatformChangePasswordScreens

Screenshots:

image

image

@vercel
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 29, 2024 8:15am

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16659](https://github.com/binary-com/deriv-app/pull/16659)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-wall-2947unit-tests-for-35a4c6.binary.sx?qa_server=red.derivws.com&app_id=23851
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-wall-2947unit-tests-for-35a4c6.binary.sx
- **App ID**: `23851`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 29, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-wall-2947unit-tests-for-35a4c6.binary.sx/

@coveralls
Copy link

coveralls commented Aug 29, 2024

Coverage Status

coverage: 46.895% (+0.2%) from 46.708%
when pulling e59bf2c on jim-deriv:jim/wall-2947/unit-tests-for-change-password
into 60c3ecf on binary-com:master.

heorhi-deriv
heorhi-deriv previously approved these changes Aug 29, 2024
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@jim-deriv jim-deriv merged commit af088c6 into deriv-com:master Aug 29, 2024
@jim-deriv jim-deriv deleted the jim/wall-2947/unit-tests-for-change-password branch August 29, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants