Skip to content

Conversation

@sandeep-deriv
Copy link
Contributor

Changes:

  1. If the server bot is open in multiple tabs or multiple browsers, then the bot should run/stop if done in one browser or tab
  2. If a bot is created/deleted it should reflect on the other browser tab -- it will happen on focus of the tab

Dev Note:

  1. If a bot is deleted then remove the subscription
  2. If a new bot is created immediately subscribe to it

@boring-cyborg boring-cyborg bot added the Bot label Sep 2, 2024
@vercel
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 2, 2024 4:18am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16683](https://github.com/binary-com/deriv-app/pull/16683)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-2154server-5831c4.binary.sx?qa_server=red.derivws.com&app_id=32205
    - **Original**: https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-2154server-5831c4.binary.sx
- **App ID**: `32205`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-2154server-5831c4.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 46.909% (-0.01%) from 46.921%
when pulling ced228f on sandeep-deriv:sandeep/bot-2154/server-bot-multiple-tab-status-issue
into 6328733 on binary-com:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants