Skip to content

Conversation

@aum-deriv
Copy link
Contributor

@aum-deriv aum-deriv commented Sep 2, 2024

Changes:

This PR is for adding unit tests to the VerificationFailed modal shown when the client tries to add MT5 accounts and their POI/POA fails. The modal pops-up when they click on Verification failed. Why? .

Screenshot 2024-09-03 at 12 04 31 PM

Screenshots:

Screenshot 2024-09-03 at 10 00 56 AM Screenshot 2024-09-03 at 10 01 03 AM

@vercel
Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 3, 2024 8:30am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16704](https://github.com/binary-com/deriv-app/pull/16704)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-aum-deriv-aum-wall-2957unit-test-wall-d351d7.binary.sx?qa_server=red.derivws.com&app_id=32108
    - **Original**: https://deriv-app-git-fork-aum-deriv-aum-wall-2957unit-test-wall-d351d7.binary.sx
- **App ID**: `32108`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-wall-2957unit-test-wall-d351d7.binary.sx/

@coveralls
Copy link

coveralls commented Sep 2, 2024

Coverage Status

coverage: 47.118% (+0.07%) from 47.049%
when pulling 13c722e on aum-deriv:aum/WALL-2957/unit-test-wallets-VerificationFailed
into 74f7bfd on binary-com:master.

@aum-deriv aum-deriv marked this pull request as ready for review September 3, 2024 08:05
@aum-deriv aum-deriv requested a review from a user September 3, 2024 08:05
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 31b3dcf into deriv-com:master Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants