Skip to content

Conversation

@balakrishna-deriv
Copy link
Contributor

@balakrishna-deriv balakrishna-deriv commented Sep 3, 2024

Changes:

Added useDtraderQuery Hook

A custom React hook for efficient data fetching with caching, refetching, and request management for DTrader API calls using the WS.send() method. This hook supports the following features:

  • Caching: Prevents duplicate requests by caching results.
  • Refetching: Allows manual data refetching with cache invalidation.
  • Loading State Management: Provides accurate is_fetching state for improved UI handling.
  • Auto-Authorization: Option to automatically wait for user authorization before making requests.
  • Configurable: Supports options like enabled to control when the query should run

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 6, 2024 5:36am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16712](https://github.com/binary-com/deriv-app/pull/16712)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-balakrishna-deriv-add-dtrader-query.binary.sx?qa_server=red.derivws.com&app_id=24104
    - **Original**: https://deriv-app-git-fork-balakrishna-deriv-add-dtrader-query.binary.sx
- **App ID**: `24104`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 36
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-balakrishna-deriv-add-dtrader-query.binary.sx/

@coveralls
Copy link

coveralls commented Sep 5, 2024

Coverage Status

coverage: 47.289% (+0.08%) from 47.21%
when pulling 943506b on balakrishna-deriv:add-dtrader-query
into f9998ff on binary-com:master.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@balakrishna-deriv balakrishna-deriv changed the title Add dtrader query Add dtrader query and fix issues with trade types Sep 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Generating Lighthouse report...

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Nov 6, 2024
@github-actions
Copy link
Contributor

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

@github-actions github-actions bot closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants