Skip to content

Conversation

@lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Sep 4, 2024

Changes:

  • Fix broken header in MT5 reset password responsive screen
  • Update strings format for WIthdrawalCryptoDisclaimer, WithdrawalCryptoReceipt and CompareAccountsDescription for crowdin integration
  • Added localize to MT5 trade details constants

Screenshots (Bug VS Fix):

364201265-837c168b-6743-4aa7-8a29-1e7643da9770

@vercel
Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 9, 2024 6:29am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16722](https://github.com/binary-com/deriv-app/pull/16722)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-wall-4837-mt5-reset-pass-62aeeb.binary.sx?qa_server=red.derivws.com&app_id=24166
    - **Original**: https://deriv-app-git-fork-lubega-deriv-wall-4837-mt5-reset-pass-62aeeb.binary.sx
- **App ID**: `24166`

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-wall-4837-mt5-reset-pass-62aeeb.binary.sx/

@coveralls
Copy link

coveralls commented Sep 4, 2024

Coverage Status

coverage: 47.213% (-0.002%) from 47.215%
when pulling f90b652 on lubega-deriv:WALL-4837/mt5-reset-password-broken-header
into 186ab98 on binary-com:master.

aizad-deriv
aizad-deriv previously approved these changes Sep 4, 2024
jim-deriv
jim-deriv previously approved these changes Sep 4, 2024
jim-deriv
jim-deriv previously approved these changes Sep 4, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Sep 4, 2024
ghost
ghost previously approved these changes Sep 4, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Generating Lighthouse report...

@heorhi-deriv heorhi-deriv merged commit 9b585b2 into deriv-com:master Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants