Skip to content

Conversation

@jim-deriv
Copy link
Contributor

@jim-deriv jim-deriv commented Sep 13, 2024

Changes:

  • Moved terms and conditions state to parent component, so that it's shared by both desktop and mobile
  • Made TnC related props optional

Screenshots:

TnC.Desktop.mov
TnC.Responsive.mov
DerivX.Add.Button.Desktop.mov
DerivX.Add.Button.Responsive.mov

@vercel
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 13, 2024 2:50am

@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16830](https://github.com/binary-com/deriv-app/pull/16830)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-webrel-3164tnc-issue.binary.sx?qa_server=red.derivws.com&app_id=32108
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-webrel-3164tnc-issue.binary.sx
- **App ID**: `32108`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 37
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-jim-deriv-jim-webrel-3164tnc-issue.binary.sx/

@rupato-deriv rupato-deriv merged commit f83f0bc into deriv-com:rc_V20240910_0 Sep 13, 2024
@jim-deriv jim-deriv deleted the jim/webrel-3164/tnc-issue branch September 13, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants