Skip to content

Conversation

@rupato-deriv
Copy link
Contributor

This is done because when this flag is set to true inside Blockly,
the handleMove function is called, which also triggers handleTouchMove
if the flag is false. This method wont be called everything will be handled in handleMove.

card: https://app.clickup.com/t/20696747/BOT-2103

@vercel
Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 17, 2024 6:52am

@rupato-deriv rupato-deriv changed the title fix: maximum call stack exceeded Rupato/BOT-2103/fix: maximum call stack exceeded Sep 17, 2024
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16865](https://github.com/binary-com/deriv-app/pull/16865)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2103maximun-c-f9f6c5.binary.sx?qa_server=red.derivws.com&app_id=23938
    - **Original**: https://deriv-app-git-fork-rupato-deriv-rupato-bot-2103maximun-c-f9f6c5.binary.sx
- **App ID**: `23938`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-rupato-deriv-rupato-bot-2103maximun-c-f9f6c5.binary.sx/

@coveralls
Copy link

coveralls commented Sep 17, 2024

Coverage Status

coverage: 52.237% (-0.001%) from 52.238%
when pulling df8b2d2 on rupato-deriv:Rupato/BOT-2103/Maximun--call-stack-exceeded
into 4c928b5 on binary-com:master.

@github-actions
Copy link
Contributor

Generating Lighthouse report...

@farabi-deriv farabi-deriv merged commit 4405123 into deriv-com:master Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants