Ameerul /Bug 68819 Design mismatch in Quick add PM Pop up on existing ads in My ads page #8112

ameerul-deriv · 2023-04-03T06:29:31Z

Changes:

Please include a summary of the change and which issue is fixed below:

Fixed design mixmatch issues with quick add modal in my ads page

When you need to add unit test

If this change disrupt current flow
If this change is adding new flow

When you need to add integration test

If components from external libraries are being used to define the flow, e.g. @deriv/components
If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

Ensure utility / function has a test case
Ensure all the tests are passing

Type of change

vercel · 2023-04-03T06:29:35Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 14, 2023 5:17am

ameerul-deriv · 2023-04-03T06:30:32Z

packages/p2p/src/stores/my-ads-store.js

    current_method = { key: null, is_deleted: false };
    delete_error_message = '';
    edit_ad_form_error = '';
+    error_code = '';


Most of the changes in the observables, actions and computed are just me rearranging it alphabetically

github-actions · 2023-04-03T06:38:36Z

A production App ID was automatically generated for this PR. (log)

PR: Ameerul /Bug 68819 Design mismatch in Quick add PM Pop up on existing ads in My ads page #8112
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-ameerul-deriv-bug-68819-design-mismat-3915eb.binary.sx?qa_server=red.binaryws.com&app_id=24229
- Original: https://deriv-app-git-fork-ameerul-deriv-bug-68819-design-mismat-3915eb.binary.sx
App ID: 24229

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/8112](https://github.com/binary-com/deriv-app/pull/8112)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-bug-68819-design-mismat-3915eb.binary.sx?qa_server=red.binaryws.com&app_id=24229
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-bug-68819-design-mismat-3915eb.binary.sx
- **App ID**: `24229`

github-actions · 2023-04-03T06:39:23Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	20
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-bug-68819-design-mismat-3915eb.binary.sx/

codecov-commenter · 2023-04-03T06:47:40Z

Codecov Report

Merging #8112 (300e335) into master (d5c38a0) will increase coverage by 20.47%.
Report is 340 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 300e335 differs from pull request most recent head 3ecb304. Consider uploading reports for the commit 3ecb304 to get more accurate results

@@             Coverage Diff             @@
##           master    #8112       +/-   ##
===========================================
+ Coverage    0.05%   20.53%   +20.47%     
===========================================
  Files         117     1637     +1520     
  Lines        3425    37058    +33633     
  Branches      893     7382     +6489     
===========================================
+ Hits            2     7610     +7608     
- Misses       3423    28697    +25274     
- Partials        0      751      +751

Files Changed	Coverage Δ
...manager/modals/quick-add-modal/quick-add-modal.jsx	`0.00% <0.00%> (ø)`
.../components/my-ads/buy-ad-payment-methods-list.jsx	`0.00% <0.00%> (ø)`
...-method-results/filter-payment-methods-results.jsx	`0.00% <0.00%> (ø)`
.../filter-payment-methods/filter-payment-methods.jsx	`0.00% <0.00%> (ø)`
...thods/add-payment-method/select-payment-method.jsx	`0.00% <0.00%> (ø)`
packages/p2p/src/stores/my-ads-store.js	`0.00% <0.00%> (ø)`

... and 1669 files with indirect coverage changes

sonarqubecloud · 2023-04-03T09:44:26Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
1.5% Duplication

sonarqubecloud · 2023-05-11T06:28:22Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.8% Duplication

github-actions · 2023-07-11T00:23:11Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

gitguardian · 2023-07-11T05:39:32Z

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	Secret	Commit	Filename
-	Generic High Entropy Secret	`59232ab`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`137b5dd`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`59232ab`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret
-	Generic High Entropy Secret	`137b5dd`	packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

github-actions · 2023-07-13T03:14:14Z

⏳ Generating Lighthouse report...

coveralls · 2023-07-13T03:48:11Z

coverage: 8.869% (-0.006%) from 8.875% when pulling 7547385 on ameerul-deriv:bug-68819-design-mismatch-quick-add-issues into 711d3e0 on binary-com:master.

…19-design-mismatch-quick-add-issues

sonarqubecloud · 2023-07-20T09:01:52Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.2% Duplication

…om:ameerul-deriv/deriv-app into bug-68819-design-mismatch-quick-add-issues

sonarqubecloud · 2023-09-14T05:07:47Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
15.8% Duplication

DerivFE · 2023-09-18T08:10:40Z

✨ PR has been merged by Paimon the Release Bot

…existing ads in My ads page (deriv-com#8112)" This reverts commit 821b221.

* Revert "Ameerul /Bug 68819 Design mismatch in Quick add PM Pop up on existing ads in My ads page (#8112)" This reverts commit 821b221. * chore: fixed imports

ameerul-deriv added 2 commits April 3, 2023 14:23

chore: fixed design changes for quick add modal

588102d

chore: added TODO

e39c0d8

boring-cyborg bot added the P2P label Apr 3, 2023

ameerul-deriv commented Apr 3, 2023

View reviewed changes

vercel bot deployed to Preview April 3, 2023 06:38 View deployment

chore: fixed logic issue for dropdown

04344aa

vercel bot deployed to Preview April 3, 2023 08:54 View deployment

chore: fixed logic issues for input

94e0d48

vercel bot deployed to Preview April 3, 2023 09:52 View deployment

farhan-nurzi-deriv previously approved these changes Apr 4, 2023

View reviewed changes

nada-deriv previously approved these changes Apr 4, 2023

View reviewed changes

Merge branch 'master' into bug-68819-design-mismatch-quick-add-issues

300e335

ameerul-deriv dismissed stale reviews from nada-deriv and farhan-nurzi-deriv via 300e335 May 11, 2023 06:23

vercel bot deployed to Preview May 11, 2023 06:55 View deployment

github-actions bot added the Stale label Jul 11, 2023

Merge branch 'master' into bug-68819-design-mismatch-quick-add-issues

59232ab

vercel bot deployed to Preview July 11, 2023 05:58 View deployment

github-actions bot removed the Stale label Jul 12, 2023

ameerul-deriv added 2 commits July 13, 2023 11:12

chore: fixed conflicts

137b5dd

chore: fixed merge conflicts

c6c3db8

chore: renamed add payment method with plural methods

ebfe138

vercel bot deployed to Preview July 13, 2023 03:49 View deployment

chore: reordered imports

9a01203

vercel bot deployed to Preview July 13, 2023 04:22 View deployment

ameerul-deriv added 2 commits July 20, 2023 15:13

Merge branch 'master' of github.com:binary-com/deriv-app into bug-688…

af1e35e

…19-design-mismatch-quick-add-issues

chore: fixed console error and logic for searching payment methods

1281b2f

vercel bot deployed to Preview July 20, 2023 08:20 View deployment

chore: replaced observer imports

e1b8e4e

vercel bot deployed to Preview July 20, 2023 08:41 View deployment

Merge branch 'master' into bug-68819-design-mismatch-quick-add-issues

7547385

vercel bot deployed to Preview July 20, 2023 09:24 View deployment

farhan-nurzi-deriv approved these changes Jul 20, 2023

View reviewed changes

nada-deriv approved these changes Jul 20, 2023

View reviewed changes

ameerul-deriv added 2 commits September 14, 2023 13:03

fix: fixed conflicts with master

5d0ec6a

Merge branch 'bug-68819-design-mismatch-quick-add-issues' of github.c…

3ecb304

…om:ameerul-deriv/deriv-app into bug-68819-design-mismatch-quick-add-issues

ameerul-deriv requested review from farrah-deriv and nijil-deriv as code owners September 14, 2023 05:04

vercel bot deployed to Preview September 14, 2023 05:17 View deployment

farrah-deriv approved these changes Sep 18, 2023

View reviewed changes

DerivFE merged commit 821b221 into deriv-com:master Sep 18, 2023

ameerul-deriv added a commit to ameerul-deriv/deriv-app that referenced this pull request Sep 19, 2023

Revert "Ameerul /Bug 68819 Design mismatch in Quick add PM Pop up on …

27130dd

…existing ads in My ads page (deriv-com#8112)" This reverts commit 821b221.

Ameerul /Bug 68819 Design mismatch in Quick add PM Pop up on existing ads in My ads page #8112

Ameerul /Bug 68819 Design mismatch in Quick add PM Pop up on existing ads in My ads page #8112

Uh oh!

Conversation

ameerul-deriv commented Apr 3, 2023

Changes:

When you need to add unit test

When you need to add integration test

Test coverage checklist (for reviewer)

Type of change

Uh oh!

vercel bot commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ameerul-deriv Apr 3, 2023

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Apr 3, 2023 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sonarqubecloud bot commented Apr 3, 2023

Uh oh!

sonarqubecloud bot commented May 11, 2023

Uh oh!

github-actions bot commented Jul 11, 2023

Uh oh!

gitguardian bot commented Jul 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Uh oh!

github-actions bot commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jul 20, 2023

Uh oh!

sonarqubecloud bot commented Sep 14, 2023

Uh oh!

DerivFE commented Sep 18, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vercel bot commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading

github-actions bot commented Apr 3, 2023 •

edited

Loading

codecov-commenter commented Apr 3, 2023 •

edited by codecov bot

Loading

gitguardian bot commented Jul 11, 2023 •

edited

Loading

github-actions bot commented Jul 13, 2023 •

edited

Loading

coveralls commented Jul 13, 2023 •

edited

Loading