Skip to content

Conversation

@henry-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Trader label May 9, 2023
@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2023 4:38am

…s-migration-unit-test-services-error-modal-folder
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/8521](https://github.com/binary-com/deriv-app/pull/8521)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-henry-deriv-henry-ts-migration-unit-t-2e047c.binary.sx?qa_server=red.binaryws.com&app_id=24046
    - **Original**: https://deriv-app-git-fork-henry-deriv-henry-ts-migration-unit-t-2e047c.binary.sx
- **App ID**: `24046`

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-ts-migration-unit-t-2e047c.binary.sx/

…s-migration-unit-test-services-error-modal-folder
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
14.6% 14.6% Duplication

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #8521 (75a8fc2) into master (d5c38a0) will increase coverage by 20.58%.
The diff coverage is 100.00%.

❗ Current head 75a8fc2 differs from pull request most recent head 319263c. Consider uploading reports for the commit 319263c to get more accurate results

@@             Coverage Diff             @@
##           master    #8521       +/-   ##
===========================================
+ Coverage    0.05%   20.63%   +20.58%     
===========================================
  Files         117     1636     +1519     
  Lines        3425    36989    +33564     
  Branches      893     7368     +6475     
===========================================
+ Hits            2     7634     +7632     
- Misses       3423    28604    +25181     
- Partials        0      751      +751     
Impacted Files Coverage Δ
...Modals/ServicesErrorModal/services-error-modal.jsx 0.00% <ø> (ø)
...ervicesErrorModal/authorization-required-modal.tsx 100.00% <100.00%> (ø)
...esErrorModal/company-wide-limit-exceeded-modal.tsx 100.00% <100.00%> (ø)
...ts/Elements/Modals/ServicesErrorModal/constants.ts 100.00% <100.00%> (ø)
.../ServicesErrorModal/insufficient-balance-modal.tsx 100.00% <100.00%> (ø)

... and 1669 files with indirect coverage changes

matin-deriv
matin-deriv previously approved these changes May 11, 2023
@github-actions
Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

Generating Lighthouse report...

@gitguardian
Copy link

gitguardian bot commented Jul 12, 2023

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Generic High Entropy Secret 3865dc2 packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
- Generic High Entropy Secret 3865dc2 packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Coverage Status

coverage: 8.861% (+0.02%) from 8.843% when pulling 319263c on henry-deriv:henry/ts-migration-unit-test-services-error-modal-folder into 119dcf3 on binary-com:master.

@github-actions github-actions bot removed the Stale label Jul 13, 2023
@sandeep-deriv sandeep-deriv merged commit 53420f8 into deriv-com:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants