-
Notifications
You must be signed in to change notification settings - Fork 396
henry/test: ts migration and test coverage for ServicesErrorModal folder #8521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
henry/test: ts migration and test coverage for ServicesErrorModal folder #8521
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s-migration-unit-test-services-error-modal-folder
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-henry-deriv-henry-ts-migration-unit-t-2e047c.binary.sx/ |
...ts/Elements/Modals/ServicesErrorModal/__tests__/account-verification-required-modal.spec.tsx
Show resolved
Hide resolved
...omponents/Elements/Modals/ServicesErrorModal/__tests__/authorization-required-modal.spec.tsx
Show resolved
Hide resolved
…s-migration-unit-test-services-error-modal-folder
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #8521 +/- ##
===========================================
+ Coverage 0.05% 20.63% +20.58%
===========================================
Files 117 1636 +1519
Lines 3425 36989 +33564
Branches 893 7368 +6475
===========================================
+ Hits 2 7634 +7632
- Misses 3423 28604 +25181
- Partials 0 751 +751
|
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
⏳ Generating Lighthouse report... |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | 3865dc2 | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
| - | Generic High Entropy Secret | 3865dc2 | packages/account/src/Components/currency-selector/tests/currency-selector.spec.tsx | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
Kudos, SonarCloud Quality Gate passed!
|









Changes:
Please include a summary of the change and which issue is fixed below:
When you need to add unit test
When you need to add integration test
Test coverage checklist (for reviewer)
Type of change