Skip to content

Conversation

@rupato-deriv
Copy link
Contributor

No description provided.

@boring-cyborg boring-cyborg bot added the Bot label Jul 7, 2023
@vercel
Copy link

vercel bot commented Jul 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 3:38am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9275](https://github.com/binary-com/deriv-app/pull/9275)
- **URLs**:
    - **w/ App ID + Server**: https://vercel.live/open-feedback/deriv-app-git-fork-rupato-deriv-rupato-remove-save-colle-9e0b93.binary.sx?qa_server=red.binaryws.com&app_id=30366
    - **Original**: https://vercel.live/open-feedback/deriv-app-git-fork-rupato-deriv-rupato-remove-save-colle-9e0b93.binary.sx
- **App ID**: `30366`

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023

Generating Lighthouse report...

@vinu-deriv vinu-deriv merged commit c1908c2 into deriv-com:refactor-connect-method-dbot Jul 7, 2023
ali-hosseini-deriv added a commit that referenced this pull request Jul 31, 2023
* Shafin/bot 188/refactor  connect removal in master (#8836)

* Revert "chore: change TToastConfig key to string"

This reverts commit ab5073b.

* refactor: self-exclusion, summary-card, summary, trade-animation

* refactor: dashboard, tour-guide, tour-slider, tour-trigger-dialog

* refactor: journal, load-modal, local-footer, local

* refactor: revert contract types

* refactor: delete-dialog, google-drive, local-footer

* refactor: remove connect from transaction, transactions

* refactor: cards, info-panel, quick-strategy

* fix: refeactored components (#8833)

* refactor: replaced connect blockly-loading,bot-footer-extensions,bot-notification-message and chart (#8832)

* refactor: replace connect method in bot-builder,workspace-wrapper,toolbar,toolbx and workspace-group (#8831)

* refactor: replace connect function in bot-notification, faq-content, guide-content and sidebar (#8827)

* refactor: replaced connect function in download, flyout-block, flyout and flyout-help-base (#8826)

* Vinu/bot 179/replace connect function (#8829)

* refactor: replaced connect in local, recet-footer, recent-workspace and recent files in bot-web-ui

* fix: add missing import in recent.tsx

* refactor: replace connect in recent-footer, recent-workspace and recent

* Vinu/refactor: replaced connect method in save-modal, stop-bot-modal and w… (#8828)

* refactor: replaced connect method in save-modal, stop-bot-modal and workspace-control files

* fix: resolved linting issue in workspace-control file

* Rupato/fix: refactored code (#8920)

* fix: refactored code

* fix: network component changes

* chore: remove connect files completely from Dbot (#8934)

* chore: destructure populateFooterExtensions from ui in bot footer

* chore: remove connect methods and MobxContentProvider completely

* chore: remove connect from test cases

* chore: remove unused props

* fix: removed any from toolbox and toolbar spec

* fix: Empty-Commit

* fix: write test cases (#9244)

* fix: removed save-collection radio button (#9275)

* fix: remove unused variables - code smells (#9292)

* fix: Trigger Build

* fix: fix console errors arising from bot-skeleton related to datadog (#9353)

* fix: fix console errors arising from bot-skeleton related to datadog

* fix: fixed the failing test cases

---------

Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com>
Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com>
Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
matin-deriv pushed a commit to matin-deriv/deriv-app that referenced this pull request Aug 2, 2023
* Shafin/bot 188/refactor  connect removal in master (deriv-com#8836)

* Revert "chore: change TToastConfig key to string"

This reverts commit ab5073b.

* refactor: self-exclusion, summary-card, summary, trade-animation

* refactor: dashboard, tour-guide, tour-slider, tour-trigger-dialog

* refactor: journal, load-modal, local-footer, local

* refactor: revert contract types

* refactor: delete-dialog, google-drive, local-footer

* refactor: remove connect from transaction, transactions

* refactor: cards, info-panel, quick-strategy

* fix: refeactored components (deriv-com#8833)

* refactor: replaced connect blockly-loading,bot-footer-extensions,bot-notification-message and chart (deriv-com#8832)

* refactor: replace connect method in bot-builder,workspace-wrapper,toolbar,toolbx and workspace-group (deriv-com#8831)

* refactor: replace connect function in bot-notification, faq-content, guide-content and sidebar (deriv-com#8827)

* refactor: replaced connect function in download, flyout-block, flyout and flyout-help-base (deriv-com#8826)

* Vinu/bot 179/replace connect function (deriv-com#8829)

* refactor: replaced connect in local, recet-footer, recent-workspace and recent files in bot-web-ui

* fix: add missing import in recent.tsx

* refactor: replace connect in recent-footer, recent-workspace and recent

* Vinu/refactor: replaced connect method in save-modal, stop-bot-modal and w… (deriv-com#8828)

* refactor: replaced connect method in save-modal, stop-bot-modal and workspace-control files

* fix: resolved linting issue in workspace-control file

* Rupato/fix: refactored code (deriv-com#8920)

* fix: refactored code

* fix: network component changes

* chore: remove connect files completely from Dbot (deriv-com#8934)

* chore: destructure populateFooterExtensions from ui in bot footer

* chore: remove connect methods and MobxContentProvider completely

* chore: remove connect from test cases

* chore: remove unused props

* fix: removed any from toolbox and toolbar spec

* fix: Empty-Commit

* fix: write test cases (deriv-com#9244)

* fix: removed save-collection radio button (deriv-com#9275)

* fix: remove unused variables - code smells (deriv-com#9292)

* fix: Trigger Build

* fix: fix console errors arising from bot-skeleton related to datadog (deriv-com#9353)

* fix: fix console errors arising from bot-skeleton related to datadog

* fix: fixed the failing test cases

---------

Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com>
Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com>
Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants