-
Notifications
You must be signed in to change notification settings - Fork 394
fix: removed save-collection radio button #9275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vinu-deriv
merged 1 commit into
deriv-com:refactor-connect-method-dbot
from
rupato-deriv:Rupato/remove-save-collection-save-modal
Jul 7, 2023
Merged
fix: removed save-collection radio button #9275
vinu-deriv
merged 1 commit into
deriv-com:refactor-connect-method-dbot
from
rupato-deriv:Rupato/remove-save-collection-save-modal
Jul 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shafin-deriv
approved these changes
Jul 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
Contributor
|
⏳ Generating Lighthouse report... |
vinu-deriv
approved these changes
Jul 7, 2023
ali-hosseini-deriv
added a commit
that referenced
this pull request
Jul 31, 2023
* Shafin/bot 188/refactor connect removal in master (#8836) * Revert "chore: change TToastConfig key to string" This reverts commit ab5073b. * refactor: self-exclusion, summary-card, summary, trade-animation * refactor: dashboard, tour-guide, tour-slider, tour-trigger-dialog * refactor: journal, load-modal, local-footer, local * refactor: revert contract types * refactor: delete-dialog, google-drive, local-footer * refactor: remove connect from transaction, transactions * refactor: cards, info-panel, quick-strategy * fix: refeactored components (#8833) * refactor: replaced connect blockly-loading,bot-footer-extensions,bot-notification-message and chart (#8832) * refactor: replace connect method in bot-builder,workspace-wrapper,toolbar,toolbx and workspace-group (#8831) * refactor: replace connect function in bot-notification, faq-content, guide-content and sidebar (#8827) * refactor: replaced connect function in download, flyout-block, flyout and flyout-help-base (#8826) * Vinu/bot 179/replace connect function (#8829) * refactor: replaced connect in local, recet-footer, recent-workspace and recent files in bot-web-ui * fix: add missing import in recent.tsx * refactor: replace connect in recent-footer, recent-workspace and recent * Vinu/refactor: replaced connect method in save-modal, stop-bot-modal and w… (#8828) * refactor: replaced connect method in save-modal, stop-bot-modal and workspace-control files * fix: resolved linting issue in workspace-control file * Rupato/fix: refactored code (#8920) * fix: refactored code * fix: network component changes * chore: remove connect files completely from Dbot (#8934) * chore: destructure populateFooterExtensions from ui in bot footer * chore: remove connect methods and MobxContentProvider completely * chore: remove connect from test cases * chore: remove unused props * fix: removed any from toolbox and toolbar spec * fix: Empty-Commit * fix: write test cases (#9244) * fix: removed save-collection radio button (#9275) * fix: remove unused variables - code smells (#9292) * fix: Trigger Build * fix: fix console errors arising from bot-skeleton related to datadog (#9353) * fix: fix console errors arising from bot-skeleton related to datadog * fix: fixed the failing test cases --------- Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
matin-deriv
pushed a commit
to matin-deriv/deriv-app
that referenced
this pull request
Aug 2, 2023
* Shafin/bot 188/refactor connect removal in master (deriv-com#8836) * Revert "chore: change TToastConfig key to string" This reverts commit ab5073b. * refactor: self-exclusion, summary-card, summary, trade-animation * refactor: dashboard, tour-guide, tour-slider, tour-trigger-dialog * refactor: journal, load-modal, local-footer, local * refactor: revert contract types * refactor: delete-dialog, google-drive, local-footer * refactor: remove connect from transaction, transactions * refactor: cards, info-panel, quick-strategy * fix: refeactored components (deriv-com#8833) * refactor: replaced connect blockly-loading,bot-footer-extensions,bot-notification-message and chart (deriv-com#8832) * refactor: replace connect method in bot-builder,workspace-wrapper,toolbar,toolbx and workspace-group (deriv-com#8831) * refactor: replace connect function in bot-notification, faq-content, guide-content and sidebar (deriv-com#8827) * refactor: replaced connect function in download, flyout-block, flyout and flyout-help-base (deriv-com#8826) * Vinu/bot 179/replace connect function (deriv-com#8829) * refactor: replaced connect in local, recet-footer, recent-workspace and recent files in bot-web-ui * fix: add missing import in recent.tsx * refactor: replace connect in recent-footer, recent-workspace and recent * Vinu/refactor: replaced connect method in save-modal, stop-bot-modal and w… (deriv-com#8828) * refactor: replaced connect method in save-modal, stop-bot-modal and workspace-control files * fix: resolved linting issue in workspace-control file * Rupato/fix: refactored code (deriv-com#8920) * fix: refactored code * fix: network component changes * chore: remove connect files completely from Dbot (deriv-com#8934) * chore: destructure populateFooterExtensions from ui in bot footer * chore: remove connect methods and MobxContentProvider completely * chore: remove connect from test cases * chore: remove unused props * fix: removed any from toolbox and toolbar spec * fix: Empty-Commit * fix: write test cases (deriv-com#9244) * fix: removed save-collection radio button (deriv-com#9275) * fix: remove unused variables - code smells (deriv-com#9292) * fix: Trigger Build * fix: fix console errors arising from bot-skeleton related to datadog (deriv-com#9353) * fix: fix console errors arising from bot-skeleton related to datadog * fix: fixed the failing test cases --------- Co-authored-by: Shafin Al Karim <129021108+shafin-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








No description provided.