Adrienne / added translations download and upload automation for crowdin #9487

adrienne-deriv · 2023-07-28T04:50:02Z

Changes:

Please provide a summary of the change.

Added automation to automatically download new translations and create/update the translations pull request when a target translation file in Crowdin has been fully approved
Added automation to upload new sources to Crowdin when commits are merged to master branch
Added Slack messages to be sent to translations team with the test link and app ID when the translations pull request is created/updated

Screenshots:

Please provide some screenshots of the change.

vercel · 2023-07-28T04:50:06Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
deriv-app	✅ Ready (Inspect)	Visit Preview	Aug 15, 2023 9:36am

github-actions · 2023-07-28T05:06:34Z

A production App ID was automatically generated for this PR. (log)

PR: Adrienne / added translations download and upload automation for crowdin #9487
URLs:
- w/ App ID + Server: https://deriv-app-git-fork-adrienne-deriv-feq-453-translations-a-525215.binary.sx?qa_server=red.binaryws.com&app_id=32193
- Original: https://deriv-app-git-fork-adrienne-deriv-feq-453-translations-a-525215.binary.sx
App ID: 32193

Click here to copy & paste above information.

- **PR**: [https://github.com/binary-com/deriv-app/pull/9487](https://github.com/binary-com/deriv-app/pull/9487)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-adrienne-deriv-feq-453-translations-a-525215.binary.sx?qa_server=red.binaryws.com&app_id=32193
    - **Original**: https://deriv-app-git-fork-adrienne-deriv-feq-453-translations-a-525215.binary.sx
- **App ID**: `32193`

github-actions · 2023-07-28T05:07:03Z

🚨 Lighthouse report for the changes in this PR:

Category	Score
🔺 Performance	21
🟧 Accessibility	75
🟢 Best practices	92
🟧 SEO	85
🟢 PWA	90

Lighthouse ran with https://deriv-app-git-fork-adrienne-deriv-feq-453-translations-a-525215.binary.sx/

coveralls · 2023-07-28T05:19:31Z

coverage: 10.018%. remained the same when pulling f1b6826 on adrienne-deriv:feq-453/translations-automation-webhook into ea0d9cc on binary-com:master.

adrienne-deriv · 2023-07-28T05:45:19Z

.github/workflows/download-translations.yml

+        id: cache_npm
+        uses: actions/cache@v3
+        with:
+          key: translations-build-${{ hashFiles('**/package-lock.json') }}


Caching the dependencies will speed up the workflow everytime the webhook event triggers (from 6.5 minutes to 1.5 minutes):

adrienne-deriv · 2023-07-28T05:46:11Z

.github/workflows/download-translations.yml

+      # - We download the latest translation files from Crowdin, if there are new files, we create a PR.
+      - name: Generate and push to Crowdin
+        run: |
+          branch_name="deriv_app_translations_2"


We create a separate branch deriv_app_translations_2 to test out the workflow first without conflicting the current translations workflow push_and_pull_crowdin_translations.yml

adrienne-deriv · 2023-07-28T05:47:21Z

.github/workflows/generate_app_id.yml

+                content+=":link: *Test Link*: ${{ steps.vercel_preview_url.outputs.vercel_preview_url }}\n"
+                content+=":id: *App ID*: ${{ steps.generate_app_id.outputs.app_id }}"
+
+                curl -X POST -H 'Content-type: application/json' --data "{\"text\": \"$content\" }" ${{ secrets.SLACK_TRANSLATIONS_TEAM_WEBHOOK }}


The message to retrieve the test link can only be generated under the issue_comment edited event, the repository_dispatch event does not contain the context for retrieving the test links

adrienne-deriv · 2023-07-28T05:48:37Z

.github/workflows/download-translations.yml

+                content+=":flag-${{ github.event.client_payload.targetLanguage.id }}: *Updated language*: $updated_language\n"
+                content+=":paperclip: *Pull Request*: $pull_request\n"
+                content+="_Paimon will soon post the generated test link for the pull request if its successful, hold on tight!_"
+                curl -X POST -H 'Content-type: application/json' --data "{\"text\": \"$content\" }" ${{ secrets.SLACK_TRANSLATIONS_TEAM_WEBHOOK }}


.github/workflows/download-translations.yml

…ng at a time

…v_app_translations_2 branch

balakrishna-deriv · 2023-07-28T05:56:40Z

.github/workflows/download-translations.yml

+  actions: write
+  checks: write
+  contents: write
+  deployments: write
+  pull-requests: write
+  statuses: write


Does it need all these permissions? 🤔

Nopee, I'll remove the unnecessary ones

.github/workflows/download-translations.yml

…ns workflow

…/translations-automation-webhook

sonarqubecloud · 2023-08-15T09:20:43Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
2.5% Duplication

github-actions · 2023-08-15T09:49:21Z

⏳ Generating Lighthouse report...

github-actions · 2023-10-15T00:21:28Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions · 2023-10-21T00:18:43Z

This PR was closed because it has been stalled for 5 days with no activity. Please reopen it if needed.

feat: added translations download and upload automation for crowdin

3ace8f1

vercel bot deployed to Preview July 28, 2023 05:06 View deployment

adrienne-deriv commented Jul 28, 2023

View reviewed changes

.github/workflows/download-translations.yml Show resolved Hide resolved

adrienne-deriv added 3 commits July 28, 2023 13:53

feat: ensure that only one workflow of download-translations is runni…

8bfdd85

…ng at a time

fix: ensure that the notification for test link is triggered for deri…

a1ecafc

…v_app_translations_2 branch

fix: ensure that previous workflow is cancelled in concurrency group

cedf684

balakrishna-deriv reviewed Jul 28, 2023

View reviewed changes

vercel bot deployed to Preview July 28, 2023 06:21 View deployment

chore: updated actions permissions for upload and download translatio…

7b09ce8

…ns workflow

balakrishna-deriv previously approved these changes Jul 28, 2023

View reviewed changes

vercel bot deployed to Preview July 28, 2023 07:36 View deployment

chore: exclude upload-translations workflow

d6efe52

adrienne-deriv dismissed balakrishna-deriv’s stale review via d6efe52 August 15, 2023 08:37

adrienne-deriv requested a review from yashim-deriv as a code owner August 15, 2023 08:37

vercel bot deployed to Preview August 15, 2023 08:54 View deployment

adrienne-deriv added 2 commits August 15, 2023 17:04

Merge branch 'master' of github.com:binary-com/deriv-app into feq-453…

f65a369

…/translations-automation-webhook

Merge branch 'master' of github.com:binary-com/deriv-app into feq-453…

f1b6826

…/translations-automation-webhook

vercel bot deployed to Preview August 15, 2023 09:36 View deployment

github-actions bot added the Stale label Oct 15, 2023

github-actions bot closed this Oct 21, 2023

Adrienne / added translations download and upload automation for crowdin #9487

Adrienne / added translations download and upload automation for crowdin #9487

Uh oh!

Conversation

adrienne-deriv commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Screenshots:

Uh oh!

vercel bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adrienne-deriv Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

adrienne-deriv Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

adrienne-deriv Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

adrienne-deriv Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adrienne-deriv Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

balakrishna-deriv Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

adrienne-deriv Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 15, 2023

Uh oh!

github-actions bot commented Aug 15, 2023

Uh oh!

github-actions bot commented Oct 15, 2023

Uh oh!

github-actions bot commented Oct 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adrienne-deriv commented Jul 28, 2023 •

edited

Loading

vercel bot commented Jul 28, 2023 •

edited

Loading

github-actions bot commented Jul 28, 2023 •

edited

Loading

github-actions bot commented Jul 28, 2023 •

edited

Loading

coveralls commented Jul 28, 2023 •

edited

Loading

adrienne-deriv Jul 28, 2023 •

edited

Loading