Skip to content

Conversation

@shontzu-deriv
Copy link
Contributor

@shontzu-deriv shontzu-deriv commented Aug 8, 2023

Changes:

changing the file extension (js -> ts)

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Aug 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Aug 8, 2023 7:03am

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@shontzu-deriv shontzu-deriv changed the title chore: js->ts shontzu/WEBREL-183/TS-migration-of-Modules-files-in-CFD-package Aug 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/9619](https://github.com/binary-com/deriv-app/pull/9619)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-shontzu-deriv-shontzu-webrel-183ts-mi-a2eaac.binary.sx?qa_server=red.binaryws.com&app_id=32186
    - **Original**: https://deriv-app-git-fork-shontzu-deriv-shontzu-webrel-183ts-mi-a2eaac.binary.sx
- **App ID**: `32186`

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-shontzu-deriv-shontzu-webrel-183ts-mi-a2eaac.binary.sx/

Copy link
Contributor

@hamza-deriv hamza-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this page?
I dont think it is used now as the CFD route is removed.
IMHO
Better to remove it.
@hirad-deriv

@shontzu-deriv
Copy link
Contributor Author

discussion link

@shontzu-deriv shontzu-deriv deleted the shontzu/WEBREL-183/TS-migration-of-Modules-files-in-CFD-package branch August 28, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants