Skip to content

Conversation

@lukelarsen
Copy link
Member

@lukelarsen lukelarsen commented Apr 1, 2020

Problem

using the containerless option on components can cause problems in that the rendered html does not have the original tag of the component. Placing if.bind and other computations on that tag is then impossible. The layout components were using containerless for some css reasons.

Solution

Refactor a few things to remove containerless from all layout components.

Side Note

All components had their html reformatted to be cleaner. That is why so many lines were added.

@lukelarsen lukelarsen merged commit cf5d832 into master Apr 1, 2020
@lukelarsen lukelarsen deleted the remove-containerless branch April 1, 2020 16:31
@github-actions
Copy link

github-actions bot commented Apr 1, 2020

Coverage Status

Coverage increased (+0.3%) to 69.056% when pulling ae73c16 on remove-containerless into 2c6508a on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants