1084 changelog #1221
1084 changelog #1221
Conversation
Use short form for private studies too. Fix qiita-spots#1164
Demux fetch bug
|
Could you also change the tutorial? Thanks. |
CHANGELOG.md
Outdated
There was a problem hiding this comment.
need -> needed --- of a study ---
There was a problem hiding this comment.
Probably changing it to:
information is usually available ...
CHANGELOG.md
Outdated
There was a problem hiding this comment.
It would also be worth linking to the mapping file documentation on QIIME.
Also worth mentioning what are the columns they need to have in the QIIME mapping file for this to work as expected.
|
One general comment on this, we probably should have the ChangeLog stick to 80 columns max, just so reviews are easier. |
|
👍 |
|
@josenavas, can you pull from upstream? Should be ready for merge, granted that someone else reviews this. |
|
@ElDeveloper I did pull from master instead that from the branch, I also tried to sync the actual branch but for some reason some commits still show in here... Unsure how can I fix it... |
|
My bad, I should have not suggested upstream/master, git should be able to resolve once this is merged into master though. The only pertinent changes people should care about are the ones shown in ChangeLog.md. |
|
Just noticed that @antgonza's comments were in fact addressed ... so. |
7 participants
Built on top of #1219
Adds the comments to the CHANGELOG of all the changes that happen during this PR.