Dealing with lint/suspicious/noMisplacedAssertion in helper functions

[ChristianIvicevic]

Pretty simple case, I have a helper function in my describe block and Biome naturally reports this. I feel like this rule only makes sense if you truly force all your assertions inside the it blocks but repeating the same set of assertions in most tests I really had to extract a reusable helper function.

Are there plans to make this rule more configurable? Maybe using an allowed prefix?

Example snippet:

describe('integration tests', () => {
	async function assertNoPartitioningApplied() {
		const clientExists = await fs.exists(clientPath)
		expect(clientExists).toBeFalsy()
		const serverExists = await fs.exists(serverPath)
		expect(serverExists).toBeFalsy()
	}

	// ...
})

[arendjr]

I think I might suggest configuring an override and disabling this rule in your tests/ folder, or wherever your test files are. This would be based on the assumption that inside a test file, your assertions can hardly be misplaced.

[ChristianIvicevic]

I was considering this, but this raises the question whether this rule has any reason to exist at all. If I were to disable it for my test files it would only ever report usages in source files which is very unlikely to happen.

[arendjr]

But isn't that the case for a lint of lint rules? There's plenty of rules for which one might say, "It's very unlikely to happen because I wouldn't make that mistake". The rule has a reason to exist if some might make the mistake.