fix: use await now warn function with decorator even if it has a call…#5485
Merged
ematipico merged 6 commits intobiomejs:mainfrom Mar 31, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #5485 will not alter performanceComparing Summary
|
ematipico
reviewed
Mar 28, 2025
Contributor
Author
|
I'm trying to understand why there is polluting whitespace in my snap, consider the PR as WIP for now :/ |
ematipico
approved these changes
Mar 31, 2025
Contributor
Author
|
Thanks @ematipico! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…back
Fixes: #4993
Summary
As mentionned in git commit message, this PR aims to fix #4993.
useAwait rule was not properly warning if decorator contained a callback.
Let me know if you need more precision or if I made a mistake: first contribution here so I could have made one.
Test Plan
I added relevant test in the related invalid.js and ensured no previous test break.