Haskell Tool Stack awareness #33
Conversation
|
Thanks! I don't use stack, but I am willing to merge this eventually. First I want to wait a bit and maybe hear feedback from other people. As you say, the automatic stack.yaml detection in your patch may break things for existing users |
jamesdbrock
force-pushed
the
stack-aware
branch
3 times, most recently
from
8204ce8 to
4868f16
Compare
|
Yeah, the automatic So if that configuration option is not set, then nothing changes. That should provide a smooth adoption path for this feature. I've also got some other commits on this branch which make some orthogonal improvements to the README, I hope you don't mind. |
|
Do you want me to squash these stack feature commits together? What's the etiquette here, clean squashed commits or transparent work process with distinct commits? |
|
This repository is simple enough such that no formal process is needed. I think this pull requests looks good. Should I merge it right now? |
If a `stack.yaml` file is found in the pwd, then hdevtools commands will be invoked by `stack exec --package hdevtools hdevtools` instead of `hdevtools`. `hdevtools` must be built with the same version of GHC as the project being inspected. With Stack support for vim-hdevtools, `hdevtools` will be built with the same version of GHC referred to by the `stack.yaml` resolver for the project, and `hdevtools` will be automatically installed locally the first time a vim-hdevtools command is run. Stack support must be enabled by `g:hdevtools_stack = 1`, otherwise vim-hdevtools will revert to the usual behavior of always looking for `hdevtools` in the `$PATH`. This will provide continuity for users who would be surprised by the new behavior if they weren't expecting it. In the future, perhaps Stack support could be enabled by default.
jamesdbrock
force-pushed
the
stack-aware
branch
from
c985754 to
699761b
Compare
|
I rebased and squashed the stack support commits and cleaned them up, ready to merge now. Thanks for maintaining this plugin @bitc ! |
2 participants
Prevent ghc version mismatch between
hdevtoolsand the project by usingstackto invokehdevtoolsinstead of looking forhdevtoolson the$PATH, to avoid issues such as hdevtools/hdevtools#78Because
hdevtoolsgenerally needs to be built with the same ghc version as the project being examined byhdevtools, there is no way to "install" a globalhdevtoolswhich works for all Haskell projects on a machine. And there is no way to solve this problem by changinghdevtools. stack and vim-hdevtools together can provide a nice solution to the problem of having a specially-builthdevtoolsfor each project.Possible problems or further work
Add a configuration option to disable
stack.yamldetection?